~kris/9p

llm9p

ref: ed43a61bf88f3238d4844391e1f7926d8490ae50 llm9p/internal/llmfs/ask_test.go -rw-r--r-- 5.0 KiB
ed43a61b — pdfinn feat(llm9p): Add per-fid session isolation and prefill support 7 months ago
                                                                                
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
package llmfs

import (
	"io"
	"testing"

	"github.com/NERVsystems/llm9p/internal/llm"
)

func TestAskFile_Read_Empty(t *testing.T) {
	mock := NewMockBackend()
	sm := llm.NewSessionManager(mock)
	ask := NewAskFile(sm)

	// Initial read with fid should be empty (EOF)
	buf := make([]byte, 100)
	n, err := ask.ReadFid(1, buf, 0)
	if err != io.EOF {
		t.Errorf("ReadFid() error = %v, want io.EOF", err)
	}
	if n != 0 {
		t.Errorf("ReadFid() n = %d, want 0", n)
	}
}

func TestAskFile_WriteRead(t *testing.T) {
	mock := NewMockBackend()
	mock.askResponse = "Hello, I'm Claude!"

	sm := llm.NewSessionManager(mock)
	ask := NewAskFile(sm)

	fid := uint32(1)

	// Write a prompt
	prompt := "Hello!"
	n, err := ask.WriteFid(fid, []byte(prompt), 0)
	if err != nil {
		t.Fatalf("WriteFid() error: %v", err)
	}
	if n != len(prompt) {
		t.Errorf("WriteFid() n = %d, want %d", n, len(prompt))
	}

	// Read response
	buf := make([]byte, 100)
	readN, err := ask.ReadFid(fid, buf, 0)
	if err != nil {
		t.Fatalf("ReadFid() error: %v", err)
	}

	response := string(buf[:readN])
	expected := "Hello, I'm Claude!\n"
	if response != expected {
		t.Errorf("ReadFid() = %q, want %q", response, expected)
	}
}

func TestAskFile_Write_EmptyNoOp(t *testing.T) {
	mock := NewMockBackend()
	sm := llm.NewSessionManager(mock)
	ask := NewAskFile(sm)

	fid := uint32(1)

	// Empty write should be no-op
	n, err := ask.WriteFid(fid, []byte(""), 0)
	if err != nil {
		t.Fatalf("WriteFid() error: %v", err)
	}
	if n != 0 {
		t.Errorf("WriteFid('') n = %d, want 0", n)
	}

	// Whitespace-only also no-op
	n, err = ask.WriteFid(fid, []byte("   \n\t  "), 0)
	if err != nil {
		t.Fatalf("WriteFid() error: %v", err)
	}
}

func TestAskFile_Write_Error(t *testing.T) {
	mock := NewMockBackend()
	mock.askError = io.ErrUnexpectedEOF

	sm := llm.NewSessionManager(mock)
	ask := NewAskFile(sm)

	fid := uint32(1)

	// Write should succeed (error is stored for read)
	n, err := ask.WriteFid(fid, []byte("test"), 0)
	if err != nil {
		t.Fatalf("WriteFid() error: %v", err)
	}
	if n != 4 {
		t.Errorf("WriteFid() n = %d, want 4", n)
	}

	// Read should return the error
	buf := make([]byte, 100)
	readN, _ := ask.ReadFid(fid, buf, 0)
	response := string(buf[:readN])

	if len(response) < 6 || response[:6] != "Error:" {
		t.Errorf("ReadFid() = %q, should start with 'Error:'", response)
	}
}

func TestAskFile_SessionIsolation(t *testing.T) {
	mock := NewMockBackend()
	mock.askResponse = "response"

	sm := llm.NewSessionManager(mock)
	ask := NewAskFile(sm)

	fid1 := uint32(1)
	fid2 := uint32(2)

	// Write to fid1
	mock.askResponse = "response for fid1"
	ask.WriteFid(fid1, []byte("prompt1"), 0)

	// Write to fid2
	mock.askResponse = "response for fid2"
	ask.WriteFid(fid2, []byte("prompt2"), 0)

	// Read from fid1 - should get fid1's response
	buf := make([]byte, 100)
	n, _ := ask.ReadFid(fid1, buf, 0)
	response1 := string(buf[:n])
	if response1 != "response for fid1\n" {
		t.Errorf("fid1 ReadFid() = %q, want %q", response1, "response for fid1\n")
	}

	// Read from fid2 - should get fid2's response
	n, _ = ask.ReadFid(fid2, buf, 0)
	response2 := string(buf[:n])
	if response2 != "response for fid2\n" {
		t.Errorf("fid2 ReadFid() = %q, want %q", response2, "response for fid2\n")
	}
}

func TestAskFile_CloseFid(t *testing.T) {
	mock := NewMockBackend()
	mock.askResponse = "response"

	sm := llm.NewSessionManager(mock)
	ask := NewAskFile(sm)

	fid := uint32(1)

	// Write to create session
	ask.WriteFid(fid, []byte("test"), 0)

	// Session should exist
	session := sm.Get(fid)
	if session == nil {
		t.Fatal("session should exist after WriteFid")
	}

	// Close the fid
	ask.CloseFid(fid)

	// Session should be removed
	session = sm.Get(fid)
	if session != nil {
		t.Error("session should be removed after CloseFid")
	}
}

func TestAskFile_Stat(t *testing.T) {
	mock := NewMockBackend()
	mock.askResponse = "Hello!"

	sm := llm.NewSessionManager(mock)
	ask := NewAskFile(sm)

	// Stat without fid context returns 0 length
	stat := ask.Stat()
	if stat.Length != 0 {
		t.Errorf("Stat().Length = %d, want 0", stat.Length)
	}
}

func TestAskFile_ResponseNewline(t *testing.T) {
	mock := NewMockBackend()
	sm := llm.NewSessionManager(mock)

	fid := uint32(1)

	// Response without trailing newline
	mock.askResponse = "No newline"
	ask := NewAskFile(sm)
	ask.WriteFid(fid, []byte("test"), 0)

	buf := make([]byte, 100)
	n, _ := ask.ReadFid(fid, buf, 0)
	response := string(buf[:n])

	// Should have newline added
	if response[len(response)-1] != '\n' {
		t.Errorf("Response should end with newline, got %q", response)
	}

	// New session for second test
	fid2 := uint32(2)

	// Response with trailing newline already
	mock.askResponse = "Has newline\n"
	ask.WriteFid(fid2, []byte("test"), 0)

	n, _ = ask.ReadFid(fid2, buf, 0)
	response = string(buf[:n])

	// Should NOT double the newline
	if response != "Has newline\n" {
		t.Errorf("Response = %q, should not double newline", response)
	}
}

func TestCompactThreshold(t *testing.T) {
	// Verify the threshold constant
	if CompactThreshold != 0.80 {
		t.Errorf("CompactThreshold = %f, want 0.80", CompactThreshold)
	}
}